WIP: Quote 0.6 #1334
Closed
WIP: Quote 0.6 #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Doesn't this break #1308 as well? |
|
Why ? Because of the |
|
Can we use it for doc comments? Or does it eat them instead? |
|
I've already tried that :p It's transforming them into |
|
☔ The latest upstream changes (presumably #1342) made this pull request unmergeable. Please resolve the merge conflicts. |
emilio
pushed a commit
to emilio/rust-bindgen
that referenced
this pull request
Oct 4, 2018
I give up on the doc comments. This is a rebase of rust-lang#1334 keeping the formatting of the comments and using TokenStream::from_str instead because one can hope. Fixes rust-lang#1407.
emilio
pushed a commit
to emilio/rust-bindgen
that referenced
this pull request
Oct 4, 2018
I give up on the doc comments. This is a rebase of rust-lang#1334 keeping the formatting of the comments and using TokenStream::from_str instead because one can hope. Fixes rust-lang#1407.
emilio
pushed a commit
to emilio/rust-bindgen
that referenced
this pull request
Nov 5, 2018
I give up on the doc comments. This is a rebase of rust-lang#1334 keeping the formatting of the comments and using TokenStream::from_str instead because one can hope. Fixes rust-lang#1407.
emilio
pushed a commit
to emilio/rust-bindgen
that referenced
this pull request
Nov 30, 2018
I give up on the doc comments. This is a rebase of rust-lang#1334 keeping the formatting of the comments and using TokenStream::from_str instead because one can hope. Fixes rust-lang#1407.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure what I should do about
#[doc]:/ Should I add a pass that replaces it back with///?CC @SimonSapin