Correct datatype for various termios constants #629
Conversation
|
☔ The latest upstream changes (presumably #640) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This also need to address |
|
|
|
@Susurrus can you rebase, and maybe merge this PR with the one that removes termios for musl ? I would like to do a libc release without this, and then, if this is ready, do a release that only contains this change. We can then try to update libc on rust upstream, and see if there is any downfall (if anybody complains). If somebody does, we can always revert the change, and yank the libc version. If nobody complains, then this would be ok. |
|
Rebased and merged #1015 into this PR. |
As of musl 1.1.20, termios2 doesn't exist in musl for any target.
|
@gnzlbg I updated and rebased this PR. What're next steps to merge this? |
Nothing. There are a couple of breaking changes in the pipeline. I'll prepare a release containing them, and see if anything breaks. If nothing breaks then that would be it. Otherwise we'll need to revert them. |
|
@bors: r+ |
|
📌 Commit 8ff57d4 has been approved by |
Correct datatype for various termios constants This was a part of #625, but I moved it to a separate PR as it's a breaking change and those are currently blocked for Tier 1 platforms.
|
💔 Test failed - checks-travis |
|
@bors: retry |
Correct datatype for various termios constants This was a part of #625, but I moved it to a separate PR as it's a breaking change and those are currently blocked for Tier 1 platforms.
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor |
This was a part of #625, but I moved it to a separate PR as it's a breaking change and those are currently blocked for Tier 1 platforms.