Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termios2 shouldn't exist on musl targets #1006

Closed
Susurrus opened this issue Jun 1, 2018 · 4 comments
Closed

termios2 shouldn't exist on musl targets #1006

Susurrus opened this issue Jun 1, 2018 · 4 comments
Labels
breakage-candidate

Comments

@Susurrus
Copy link
Contributor

Susurrus commented Jun 1, 2018

musl doesn't include the termios2 API, but those structs are declared by libc. They should be removed.
@Susurrus Susurrus mentioned this issue Jun 2, 2018
Closed
@gnzlbg
Copy link
Contributor

gnzlbg commented May 24, 2019

I think we can go ahead and do this breaking change, care to submit a PR ?

@Susurrus
Copy link
Contributor Author

I already have a PR in #629, however it contains other breaking changes to datatypes around termios. Do you want me to break it out as a separate PR or is that whole PR on the table for merging?

@gnzlbg
Copy link
Contributor

gnzlbg commented May 28, 2019 •
edited
Loading

Separate PR would be better (EDIT: #629 has been merged).

@Susurrus
Copy link
Contributor Author

I think this can be closed now that #629 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breakage-candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Susurrus @gnzlbg