Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.2] ci: Naming adjustments and cleanup #4126

Merged
merged 15 commits into from
Nov 20, 2024
Merged

[0.2] ci: Naming adjustments and cleanup #4126

merged 15 commits into from
Nov 20, 2024

Commits on Nov 20, 2024

  1. ci: Ensure build channels get run even if FILTER is unset 

    In 59a18de("ci: Set `-u` (error on unset)..."), `-u` started being
passed to the `set` call in shell scripts. This broke the `FILTER` logic
since now the command always fails.

Make this a bit less fragile by explicitly setting to an empty string,
as well as adding a check that at least one test got run.

(backport <rust-lang#4125>)
(cherry picked from commit 084f370)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bcb4107 View commit details
    Browse the repository at this point in the history

  2. ci: Ensure there is a fallback for no_std 

    (backport <rust-lang#4125>)
(cherry picked from commit 907c6d6)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4bfd0dc View commit details
    Browse the repository at this point in the history

  3. ci: Rename main workflow and use .yaml extension 

    We no longer have two separate workflows, so rename `full_ci` to just
`ci`.

Additionally, `.yaml` is the preferred extension [1], so rename the
other `.yml` file to `.yaml`.

[1]: https://yaml.org/faq.html

(backport <rust-lang#4124>)
(cherry picked from commit 4c96512)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    92597e6 View commit details
    Browse the repository at this point in the history

  4. ci: Use ./ with shebangs rather than sh or bash 

    The scripts say how they should execute, there isn't any reason to
duplicate this wherever they are called.

(backport <rust-lang#4124>)
(cherry picked from commit 4707c5d)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3e48e4b View commit details
    Browse the repository at this point in the history

  5. ci: use env rather than passing environment inline 

    (backport <rust-lang#4124>)
(cherry picked from commit 58265b9)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    129909d View commit details
    Browse the repository at this point in the history

  6. ci: combine and export RUSTFLAGS rather than passing inline 

    This cleans things up and allows us to pass more flags externally.

(backport <rust-lang#4124>)
(cherry picked from commit 67988b7)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    af6fc9e View commit details
    Browse the repository at this point in the history

  7. ci: Reduce redundant commands in build.sh 

    (backport <rust-lang#4124>)
(cherry picked from commit bbf941b)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    36ce4a0 View commit details
    Browse the repository at this point in the history

  8. ci: Reduce redundant commands in run.sh 

    (backport <rust-lang#4124>)
(cherry picked from commit c90236b)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ec54c2e View commit details
    Browse the repository at this point in the history

  9. ci: Replace $1 with a binding in run-docker.sh 

    (backport <rust-lang#4124>)
(cherry picked from commit 3faaf4d)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8f6d1fe View commit details
    Browse the repository at this point in the history

  10. ci: Switch to a single matrix for build channels (verify_build) 

    The Mac, Windows, and Linux jobs for build channels are pretty
redundant. Turn this into a single `verify_build` job that has both OS
and version in its matrix. For consistency, rename the script to
`verify-build`.

To simplify variables, allow the build and toolchain scripts to detect
the OS rather than passing it from CI.

(backport <rust-lang#4124>)
(cherry picked from commit c4e3ff8)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b2425ee View commit details
    Browse the repository at this point in the history

  11. ci: Switch to a single matrix for tier1 testing 

    The Mac, Windows, and Linux jobs for testing are pretty redundant.  Turn
this into a single `test_tier1` job that runs all expected combinations.

(backport <rust-lang#4124>)
(cherry picked from commit 01244c5)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4fa42c8 View commit details
    Browse the repository at this point in the history

  12. ci: Make sure sparc is the first job run then sort the others 

    (backport <rust-lang#4124>)
(cherry picked from commit 33582fc)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    769bc10 View commit details
    Browse the repository at this point in the history

  13. ci: defer the Solaris job until after tier 1 

    Solaris is a Tier 2 target so defer it until after tier1 completes. We
currently do this for the other T2 targets. In preparation of adding
other VM tests to the matrix, adjust naming.

Additionally, just `set -x` rather than priting the commands before
running them.

(backport <rust-lang#4124>)
(cherry picked from commit 549eb77)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4a7cde5 View commit details
    Browse the repository at this point in the history

  14. ci: Update all jobs to the latest ubuntu-24.04 

    (backport <rust-lang#4124>)
(cherry picked from commit 09a2bcf)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0961b87 View commit details
    Browse the repository at this point in the history

  15. ci: Remove some trailing whitespace 

    (backport <rust-lang#4124>)
(cherry picked from commit 0892b44)
    @tgross35
    tgross35 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7a897dd View commit details
    Browse the repository at this point in the history