ci: Naming adjustments and cleanup #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
tgross35
changed the title
tgross35
force-pushed
the
ci-naming
branch
9 times, most recently
from
ddb7fe1
to
5b7dd81
Compare
tgross35
added
the
stable-nominated
tgross35
force-pushed
the
ci-naming
branch
14 times, most recently
from
fb54029
to
07abe08
Compare
|
☔ The latest upstream changes (presumably #4125) made this pull request unmergeable. Please resolve the merge conflicts. |
The Mac, Windows, and Linux jobs for build channels are pretty redundant. Turn this into a single `verify_build` job that has both OS and version in its matrix. For consistency, rename the script to `verify-build`. To simplify variables, allow the build and toolchain scripts to detect the OS rather than passing it from CI.
The Mac, Windows, and Linux jobs for testing are pretty redundant. Turn this into a single `test_tier1` job that runs all expected combinations.
Solaris is a Tier 2 target so defer it until after tier1 completes. We currently do this for the other T2 targets. In preparation of adding other VM tests to the matrix, adjust naming. Additionally, just `set -x` rather than priting the commands before running them.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
We no longer have two separate workflows, so rename `full_ci` to just `ci`. Additionally, `.yaml` is the preferred extension [1], so rename the other `.yml` file to `.yaml`. [1]: https://yaml.org/faq.html (backport <rust-lang#4124>) (cherry picked from commit 4c96512)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
The scripts say how they should execute, there isn't any reason to duplicate this wherever they are called. (backport <rust-lang#4124>) (cherry picked from commit 4707c5d)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
(backport <rust-lang#4124>) (cherry picked from commit 58265b9)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
This cleans things up and allows us to pass more flags externally. (backport <rust-lang#4124>) (cherry picked from commit 67988b7)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
(backport <rust-lang#4124>) (cherry picked from commit bbf941b)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
(backport <rust-lang#4124>) (cherry picked from commit c90236b)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
(backport <rust-lang#4124>) (cherry picked from commit 3faaf4d)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
The Mac, Windows, and Linux jobs for build channels are pretty redundant. Turn this into a single `verify_build` job that has both OS and version in its matrix. For consistency, rename the script to `verify-build`. To simplify variables, allow the build and toolchain scripts to detect the OS rather than passing it from CI. (backport <rust-lang#4124>) (cherry picked from commit c4e3ff8)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
The Mac, Windows, and Linux jobs for testing are pretty redundant. Turn this into a single `test_tier1` job that runs all expected combinations. (backport <rust-lang#4124>) (cherry picked from commit 01244c5)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
(backport <rust-lang#4124>) (cherry picked from commit 33582fc)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
Solaris is a Tier 2 target so defer it until after tier1 completes. We currently do this for the other T2 targets. In preparation of adding other VM tests to the matrix, adjust naming. Additionally, just `set -x` rather than priting the commands before running them. (backport <rust-lang#4124>) (cherry picked from commit 549eb77)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
(backport <rust-lang#4124>) (cherry picked from commit 09a2bcf)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
(backport <rust-lang#4124>) (cherry picked from commit 0892b44)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make job names more clear, leverage GHA matrix some more, and clean up some shell scripts.