Add unit tests from the smoke test PR #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
changed the title
|
This PR is best reviewed commit-by-commit. |
This was referenced Feb 2, 2020
Closed
yvrhdn
reviewed
Feb 10, 2020
src/test/mod.rs
Outdated
| @@ -43,7 +43,11 @@ pub(crate) fn assert_redirect(path: &str, expected_target: &str, web: &TestFront | |||
| let status = response.status(); | |||
|
|
|||
| // Reqwest follows redirects automatically | |||
There was a problem hiding this comment.
This might be a bit nit-picky... but I find this comment confusing now. This comment originally had a slightly different place/context. Now it seems to tell us something about the conversion of response to redirect_target, but the redirect has already happened by the time we get here.
I would propose:
- move this comment up a bit, maybe at
let response = web.get(path).send()?;? - perhaps add a (short) comment at
let redirect_target = if ...to clarify why we sometimes take the full URL and sometimes the path only.
There was a problem hiding this comment.
I pushed a change that comments this, does that make it more clear?
- add `source_files()` - add /:crate/:version/:name/index.html if it doesn't already exist - add source files as rustdoc files
yvrhdn
approved these changes
Feb 11, 2020
This was referenced Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsoletes #524.
This is ready for review.
Things to do:
/crate/:crate/:version