Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta] add more tests #551

Open
2 tasks done
jyn514 opened this issue Jan 8, 2020 · 5 comments
Open
2 tasks done

[meta] add more tests #551

jyn514 opened this issue Jan 8, 2020 · 5 comments
Labels
A-builds Area: Building the documentation for a crate C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users P-high High priority

Comments

@jyn514
Copy link
Member

jyn514 commented Jan 8, 2020 •
edited
Loading

Most of these are partially addressed in #524, but it would be better to have unit tests.

Off the top of my head:

  • proc macros should work (but only for default target because of bugs in cargo)
  • all targets are built
  • anything that's not only bin is built, including cdylib, rlib, etc.
  • viewing source works (Add unit tests from the smoke test PR #570 )
  • building with docker-compose from scratch (no cache) works (expensive, doesn't need to be run on every commit)
    • including on hosts other than x86_64-unknown-linux-gnu
  • renamed crates work (e.g. constellation-rs -> constellation)
  • 'go to latest version' works and doesn't crash (Add unit tests from the smoke test PR #570 )
  • A default-target other than the host builds successfully and is uploaded to the database as the default target

This would make me much more comfortable fixing #544 and #459.
@jyn514 jyn514 added A-builds Area: Building the documentation for a crate C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users P-high High priority S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jul 6, 2020
@jyn514
Copy link
Member Author

jyn514 commented Jul 6, 2020

Blocked on #822

@Kixiron
Copy link
Member

Kixiron commented Jul 19, 2020

Crates that depend on yanked crates #903

@jyn514
Copy link
Member Author

jyn514 commented Jul 19, 2020

Crates that depend on yanked crates #903

These should give an error and show up on the website as a failed build, they shouldn't succeed.

@Nemo157
Copy link
Member

Nemo157 commented Jul 19, 2020

The build failure that #903 is referencing isn't from a yanked crate, it's failing because the semver version constraint specified is unsatisfiable, it required something matching ^1.0.0 but the only available version was 0.1.2; which I don't think was yanked at that point (the logs were from 17:09, the crate was yanked at 17:42). The error message in that case just seems to be incorrect.

@jyn514
Copy link
Member Author

jyn514 commented Jul 19, 2020

The error message in that case just seems to be incorrect.

Sounds like a rustwide bug.

@syphar syphar mentioned this issue Mar 7, 2021
Merged
@jyn514 jyn514 removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-builds Area: Building the documentation for a crate C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users P-high High priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nemo157 @jyn514 @Kixiron