remove the non-existent id in the results selector #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zomg you're awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Sorry to show up randomly, but @carols10cents pinged me on the twitters and I took a look at the failing travis build here and noticed something that will (hopefully) be an easy fix. The test that's been failing is (I'm assuming) attempting to scope the
findfunction using by specifying anidas part of the selector, e.g.#crate-all-reverse-dependencies.This is definitely a common practice in Ember-qunit land, but in this case that
iddoesn't appear to actually exist anywhere.I know some other things have been going on with qunit and some weird upgrade issues, but I suspect that in this case, the strange
assert.asyncerror you were seeing is simply a case of a bad error message for a relatively simple fluke.Anyway, I've pulled out the
idfor now. If you decided you want to re-scope them, we could scope on the parent class,white-rows, but that's a style-related class so it feels weird. Otherwise we can just add an id or data-attribute to scope on if need be.This should (hopefully) also fix the failing tests in #552