-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 7-day moving averages to download graph. Plus UI tweaks. #552
Add 7-day moving averages to download graph. Plus UI tweaks. #552
Conversation
Thanks, this looks awesome!! 🎁 Since you sent in this PR, we've upgraded ember, which seems to have gotten rid of |
welp that didn't work, investigating.... |
I think this is hitting ember-cli/ember-cli-qunit#162 now... |
I haven't looked into the newly appeared issue, but if it's only about the lodash usage, I think I can rewrite this without using lodash. It was just convenient to have it. |
The non-stacked scattered chart as a basis reflects the download numbers correctly. The stacked area chart before was a bit midleading. Both approaches are a bit "noisy", so I added a 7-day moving average line for each version number. This gives a higher-level overview and also makes it easy to see when new versions overtake older ones in usage. The colors were chosen to be colorblindness-friendly as well as having a hot-cold metaphor.
3d02252
to
fae4553
Compare
Turns out it was my fault :) I just rebased and force pushed to pick up this change: #562 I think lodash is convenient too, seems fine. Let's see if this goes green. |
Yaaay, tests are green!!! 🍏 📗 💚 🥗 Tested it out locally and it's looking awesome! Thank you for your patience!! |
Just my two cents: I saw the new graphs and I thought something was broken. Now reading this I like the moving average idea, but I think it needs to be indicated in the legend somehow. |
I would even suggest removing the noisy dots. Or have a toggle to switch between averaged and raw data. |
Please open a new issue since this has been merged. Thanks!
On Feb 22, 2017 10:59 AM, "Alex Burka" <[email protected]> wrote:
I would even suggest removing the noisy dots. Or have a toggle to switch
between averaged and raw data.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#552 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAL1UqHEJxwcqTFSeTOFwppVb8ZCzXRvks5rfFtngaJpZM4L9ZsF>
.
|
Loving the color selection and the use of a rolling average. Agreed with @durka that the dots initially made me think that something was broken, and I'd second a PR to remove them from the main graph (though I think it's useful to retain the raw data in the hover). |
The non-stacked scattered chart as a basis reflects the download numbers
correctly. The stacked area chart before was a bit midleading. Both
approaches are a bit "noisy", so I added a 7-day moving average line for
each version number. This gives a higher-level overview and also makes it
easy to see when new versions overtake older ones in usage.
The colors were chosen to be colorblindness-friendly as well as having
a hot-cold metaphor.
Example, the futures crate, before and after: