-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend target policy to require codegen support #655
Labels
major-change
A proposal to make a major change to rustc
major-change-accepted
A major change proposal that was accepted
T-compiler
Add this label so rfcbot knows to poll the compiler team
Comments
workingjubilee
added
major-change
A proposal to make a major change to rustc
T-compiler
Add this label so rfcbot knows to poll the compiler team
labels
Jul 17, 2023
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. cc @rust-lang/compiler @rust-lang/compiler-contributors |
@rustbot second |
rustbot
added
the
final-comment-period
The FCP has started, most (if not all) team members are in agreement
label
Jul 17, 2023
compiler-errors
added
major-change-accepted
A major change proposal that was accepted
and removed
final-comment-period
The FCP has started, most (if not all) team members are in agreement
labels
Jul 29, 2023
This MCP is accepted. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Dec 11, 2023
…t, r=Mark-Simulacrum tests: add sanity-check assembly test for every target Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? `@wesleywiser`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Dec 11, 2023
…t, r=Mark-Simulacrum tests: add sanity-check assembly test for every target Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? ``@wesleywiser``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Dec 11, 2023
…t, r=Mark-Simulacrum tests: add sanity-check assembly test for every target Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? ```@wesleywiser```
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 11, 2024
… r=Mark-Simulacrum tests: add sanity-check assembly test for every target Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? `@wesleywiser`
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 11, 2024
… r=Mark-Simulacrum tests: add sanity-check assembly test for every target Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? `@wesleywiser`
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 12, 2024
… r=Mark-Simulacrum tests: add sanity-check assembly test for every target Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? `@wesleywiser`
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 12, 2024
… r=Mark-Simulacrum tests: add sanity-check assembly test for every target Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? `@wesleywiser`
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 15, 2024
… r=Mark-Simulacrum tests: add sanity-check assembly test for every target Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? `@wesleywiser`
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 17, 2024
… r=Mark-Simulacrum tests: add sanity-check assembly test for every target Fixes rust-lang#119910. Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? `@wesleywiser`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this issue
Jan 18, 2024
…imulacrum tests: add sanity-check assembly test for every target Fixes #119910. Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this. cc rust-lang/compiler-team#655 r? `@wesleywiser`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
major-change
A proposal to make a major change to rustc
major-change-accepted
A major change proposal that was accepted
T-compiler
Add this label so rfcbot knows to poll the compiler team
Proposal
We may wish to adopt the recommendation by @nikic to amend the target tier policy to explicitly require codegen support for all target architectures that rustc actually supports. While strongly implied123 by the policy, it's left slightly ambiguous. Recent events have undermined certainty that all targets in-tree functionally support even emitting object code, leading to inadequate returns on our own maintenance efforts.
More specifically, I would elaborate this to require:
Mentors or Reviewers
@nikic?
@workingjubilee?
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
Footnotes
"Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries" suggests that such compilation can be done but does not directly state that it can happen. ↩
"Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality)," does not explicitly say, say, addition should work. ↩
"Tier 2 targets must not leave any significant portions of core or the standard library unimplemented or stubbed out, unless they cannot possibly be supported on the target." does not specify, for instance, that these implementations should emit the correct object code and survive even minimal testing... it just seems reasonable to imagine they would. ↩
The text was updated successfully, but these errors were encountered: