Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asmjs-unknown-emscripten produces wasm because of changed defaults in Emscripten #51856

Closed
badboy opened this issue Jun 27, 2018 · 3 comments · Fixed by #117338
Closed

asmjs-unknown-emscripten produces wasm because of changed defaults in Emscripten #51856

badboy opened this issue Jun 27, 2018 · 3 comments · Fixed by #117338
Labels
C-bug Category: This is a bug. O-asmjs Target: asm.js - http://asmjs.org/ O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@badboy
Copy link
Member

badboy commented Jun 27, 2018

Emscripten recently introduced a breaking change defaulting to Wasm generation instead of asmjs (in v1.38.1 from 05/17/2018, changelog).

It now requires -s WASM=0 to be passed to disable this behavior. It seems like that should be fine for older Emscripten as well, so we could just pass it unconditionally.

I'd like to add this myself tomorrow.
@bors bors closed this as completed in 8983ff5 Jun 29, 2018
@Serentty
Copy link
Contributor

It seems like this is happening again, if Compiler Explorer is anything to go by.

@workingjubilee workingjubilee added O-asmjs Target: asm.js - http://asmjs.org/ C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. labels Jul 17, 2023
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 17, 2023
@workingjubilee
Copy link
Member

Regressed in Rust 1.40, Godbolt.

@workingjubilee workingjubilee added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 17, 2023
@workingjubilee workingjubilee mentioned this issue Jul 17, 2023
Closed
3 tasks
@workingjubilee
Copy link
Member

Judging by many exceptions carved into the codebase in this general direction, it appears it has been believed that "asmjs is just another way to say wasm32" when that is not the case at all?

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 17, 2023
@workingjubilee workingjubilee mentioned this issue Jul 21, 2023
Closed
@workingjubilee workingjubilee mentioned this issue Aug 26, 2023
Closed
3 tasks
@workingjubilee workingjubilee linked a pull request Oct 29, 2023 that will close this issue
Remove asmjs #117338
Merged
@workingjubilee workingjubilee added the O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. O-asmjs Target: asm.js - http://asmjs.org/ O-emscripten Target: 50% off wasm32-unknown-musl. the savings come out of stdio.h, but hey, you get SDL! regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove asmjs workingjubilee/rustc
5 participants
@badboy @Serentty @apiraino @workingjubilee @rustbot