Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_flag_supported not using compiler specified by user #675

Closed
Ast-x64 opened this issue Apr 26, 2022 · 0 comments · Fixed by #676
Closed

is_flag_supported not using compiler specified by user #675

Ast-x64 opened this issue Apr 26, 2022 · 0 comments · Fixed by #676

Comments

@Ast-x64
Copy link
Contributor

Ast-x64 commented Apr 26, 2022

Currently is_flag_supported creates a new cfg to detect whether the given flag could be accepted, inheriting some configurations (target, host, cpp etc.) except compiler. This means though the compiler to use may have been specified explicitly, the flag is still tested with the default compiler instead, resulting in wrong configurations.
Ast-x64 added a commit to Ast-x64/cc-rs that referenced this issue Apr 26, 2022
@Ast-x64
Use specified compiler in is_flag_supported
cbd247a 
Use the compiler specified instead of the default one to test whether a
flag can be accepted.
Fixes rust-lang#675.
@Ast-x64 Ast-x64 mentioned this issue Apr 26, 2022
Merged
Ast-x64 added a commit to Ast-x64/cc-rs that referenced this issue Apr 27, 2022
@Ast-x64
Use specified compiler in is_flag_supported
ffb9305 
Use the compiler specified instead of the default one to test whether a
flag can be accepted.
Fixes rust-lang#675.
Ast-x64 added a commit to Ast-x64/cc-rs that referenced this issue Jul 26, 2022
@Ast-x64
Use specified compiler in is_flag_supported
5cf9960 
Use the compiler specified instead of the default one to test whether a
flag can be accepted.
Fixes rust-lang#675.
Ast-x64 added a commit to Ast-x64/cc-rs that referenced this issue Oct 29, 2022
@Ast-x64
Use specified compiler in is_flag_supported
160d39e 
Use the compiler specified instead of the default one to test whether a
flag can be accepted.
Fixes rust-lang#675.
thomcc pushed a commit that referenced this issue Oct 29, 2022
@Ast-x64 @thomcc
Use specified compiler in is_flag_supported
3eeb50b 
Use the compiler specified instead of the default one to test whether a
flag can be accepted.
Fixes #675.
@palfrey palfrey mentioned this issue Oct 29, 2022
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 7, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103744 - palfrey:unwind-upgrade-cc, r=Mark-…
847cad3 
…Simulacrum

Upgrade cc for working is_flag_supported on cross-compiles

rust-lang#85806 fixed unwind v.s gcc support on later Android ndks using `is_flag_supported`. However, due to rust-lang/cc-rs#675, this didn't work properly on cross-compiles. rust-lang/cc-rs@3eeb50b fixes this, and was released in cc 1.0.74, hence the upgrade
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 7, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103744 - palfrey:unwind-upgrade-cc, r=Mark-…
070107c 
…Simulacrum

Upgrade cc for working is_flag_supported on cross-compiles

rust-lang#85806 fixed unwind v.s gcc support on later Android ndks using `is_flag_supported`. However, due to rust-lang/cc-rs#675, this didn't work properly on cross-compiles. rust-lang/cc-rs@3eeb50b fixes this, and was released in cc 1.0.74, hence the upgrade
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 8, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103744 - palfrey:unwind-upgrade-cc, r=Mark-…
7109009 
…Simulacrum

Upgrade cc for working is_flag_supported on cross-compiles

rust-lang#85806 fixed unwind v.s gcc support on later Android ndks using `is_flag_supported`. However, due to rust-lang/cc-rs#675, this didn't work properly on cross-compiles. rust-lang/cc-rs@3eeb50b fixes this, and was released in cc 1.0.74, hence the upgrade
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 8, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103744 - palfrey:unwind-upgrade-cc, r=Mark-…
00fe93c 
…Simulacrum

Upgrade cc for working is_flag_supported on cross-compiles

rust-lang#85806 fixed unwind v.s gcc support on later Android ndks using `is_flag_supported`. However, due to rust-lang/cc-rs#675, this didn't work properly on cross-compiles. rust-lang/cc-rs@3eeb50b fixes this, and was released in cc 1.0.74, hence the upgrade
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 8, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103744 - palfrey:unwind-upgrade-cc, r=Mark-…
05cbd26 
…Simulacrum

Upgrade cc for working is_flag_supported on cross-compiles

rust-lang#85806 fixed unwind v.s gcc support on later Android ndks using `is_flag_supported`. However, due to rust-lang/cc-rs#675, this didn't work properly on cross-compiles. rust-lang/cc-rs@3eeb50b fixes this, and was released in cc 1.0.74, hence the upgrade
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 14, 2022
@Manishearth
Rollup merge of rust-lang#103744 - palfrey:unwind-upgrade-cc, r=Mark-…
c9fc5cb 
…Simulacrum

Upgrade cc for working is_flag_supported on cross-compiles

rust-lang#85806 fixed unwind v.s gcc support on later Android ndks using `is_flag_supported`. However, due to rust-lang/cc-rs#675, this didn't work properly on cross-compiles. rust-lang/cc-rs@3eeb50b fixes this, and was released in cc 1.0.74, hence the upgrade
thomcc pushed a commit to tcdi/postgrestd that referenced this issue Feb 10, 2023
@Manishearth
Rollup merge of #103744 - palfrey:unwind-upgrade-cc, r=Mark-Simulacrum
e8be151 
Upgrade cc for working is_flag_supported on cross-compiles

rust-lang/rust#85806 fixed unwind v.s gcc support on later Android ndks using `is_flag_supported`. However, due to rust-lang/cc-rs#675, this didn't work properly on cross-compiles. rust-lang/cc-rs@3eeb50b fixes this, and was released in cc 1.0.74, hence the upgrade
@r-value r-value mentioned this issue May 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use specified compiler in is_flag_supported Ast-x64/cc-rs
1 participant
@Ast-x64