Use specified compiler in is_flag_supported #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
This seems very reasonable.
Can you rebase in order to retrigger CI? I'm not sure why the windows checks are cancelled, but because it's old the logs are gone, so it's not clear what happened. (Also because it's old, github won't let me retrigger it from here).
(P.S. sorry for the delay on this review, should be better moving forward)
Use the compiler specified instead of the default one to test whether a flag can be accepted. Fixes rust-lang#675.
Ast-x64
force-pushed
the
fix-flag-supported-compiler
branch
from
cbd247a to
160d39e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the compiler specified instead of the default one to test whether a flag can be accepted.
Fixes #675.