Fix 2 tests for offline execution #13789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `alt_registry::warn_for_unused_fields`, the second part of the test runs on `--registry crates-io`, so it needs a local replacement url. In `install::install_global_cargo_config`, it was adding to the "config" file, but the `pkg` before it configured the dummy registry replacement in "config.toml". So that replacement wasn't actually used, and if you ran tests online it was trying to install `bar v0.1.1` from the real registry! The filename is now fixed, and the test double-checks that we're only trying to install the local `bar v0.0.1`.
rustbot
added
the
S-waiting-on-review
weihanglo
approved these changes
Apr 23, 2024
|
Wow. Thanks for the findings! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2024
Update cargo 7 commits in 80d5b607dde6ef97dfff4e23923822c01d2bb036..c9392675917adc2edab269eea27c222b5359c637 2024-04-19 18:39:22 +0000 to 2024-04-23 19:35:19 +0000 - fix(install): Don't respect MSRV for non-local installs (rust-lang/cargo#13790) - gate some libc usages under cfg(unix), drop os_info features (rust-lang/cargo#13782) - feat(resolver): Add default Edition2024 to resolver v3 (rust-lang/cargo#13785) - Fix 2 tests for offline execution (rust-lang/cargo#13789) - fix(toml): Report `_` fied variants (e.g. `dev_dependencies`) as deprecated (rust-lang/cargo#13783) - feat(resolver): Add v3 resolver for MSRV-aware resolving (rust-lang/cargo#13776) - Unused dependencies cleanup (rust-lang/cargo#13778) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
alt_registry::warn_for_unused_fields, the second part of the testruns on
--registry crates-io, so it needs a local replacement url.In
install::install_global_cargo_config, it was adding to the "config"file, but the
pkgbefore it configured the dummy registry replacementin "config.toml". So that replacement wasn't actually used, and if you
ran tests online it was trying to install
bar v0.1.1from the realregistry! The filename is now fixed, and the test double-checks that
we're only trying to install the local
bar v0.0.1.