fix(toml): Report _ fied variants (e.g. dev_dependencies) as deprecated
#13783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-manifest
epage
force-pushed
the
underscore
branch
2 times, most recently
from
938cec9
to
d1f0247
Compare
|
Thanks! |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2024
Update cargo 7 commits in 80d5b607dde6ef97dfff4e23923822c01d2bb036..c9392675917adc2edab269eea27c222b5359c637 2024-04-19 18:39:22 +0000 to 2024-04-23 19:35:19 +0000 - fix(install): Don't respect MSRV for non-local installs (rust-lang/cargo#13790) - gate some libc usages under cfg(unix), drop os_info features (rust-lang/cargo#13782) - feat(resolver): Add default Edition2024 to resolver v3 (rust-lang/cargo#13785) - Fix 2 tests for offline execution (rust-lang/cargo#13789) - fix(toml): Report `_` fied variants (e.g. `dev_dependencies`) as deprecated (rust-lang/cargo#13783) - feat(resolver): Add v3 resolver for MSRV-aware resolving (rust-lang/cargo#13776) - Unused dependencies cleanup (rust-lang/cargo#13778) r? ghost
epage
added a commit
to epage/cargo
that referenced
this pull request
Apr 24, 2024
During rust-lang#13783, I had considered making the 2024 edition behavior a "unused key" warning. However, I'm being too lazy in piping the data through correctly (and a hard error might be better to help users transition).
bors
added a commit
that referenced
this pull request
Apr 24, 2024
fix(toml): Be more forceful with underscore/dash redundancy ### What does this PR try to resolve? This is prep for removing them in the 2024 Edition and is part of rust-lang/rust#123754 and #13629 During #13783, I had considered making the 2024 edition behavior a "unused key" warning. However, the work and code mess to pipe the data through correctly handle the two fields in all cases didn't seem worth it (and a hard error might be better to help users transition). ### How should we test and review this PR? ### Additional information
dburgener
added a commit
to dburgener/cascade
that referenced
this pull request
May 2, 2024
The _ variants of several Cargo fields will be deprecated in the 2024 edition. Switch to the recommended - variants. rust-lang/cargo#13783
dburgener
added a commit
to dburgener/lalrpop
that referenced
this pull request
May 2, 2024
The _ variants of several Cargo fields will be deprecated in the 2024 edition. Switch to the recommended - variants. rust-lang/cargo#13783
This was referenced May 2, 2024
dburgener
added a commit
to dburgener/cascade
that referenced
this pull request
May 2, 2024
The _ variants of several Cargo fields will be deprecated in the 2024 edition. Switch to the recommended - variants. rust-lang/cargo#13783
github-merge-queue bot
pushed a commit
to lalrpop/lalrpop
that referenced
this pull request
May 3, 2024
The _ variants of several Cargo fields will be deprecated in the 2024 edition. Switch to the recommended - variants. rust-lang/cargo#13783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is prep for removing them in the 2024 Edition and is part of rust-lang/rust#123754 and #13629
This doesn't include 2024 Edition work because there is a risk of conflict with other work going on these areas.
This changes us from
-and_variants: deprecated, will error some timeTo
-and_variants: unused field warning_: deprecation, will be removed in 2024I decided to model this as an unused field warning because that is what this is and that is how any other use of
_works. We might hard error during a transition period but I'd eventually want these to just make the code act like anything else in the end.How should we test and review this PR?
Additional information