Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta-1.75.0] chore: bump cargo-credential-* crates as e58b84d broke stuff #13009

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Nov 19, 2023

e58b84d changed the shape of response of cargo credential protocol trait,
so credential plugins crates effectively depend on [email protected].
However, [email protected] still depends on[email protected].
They must depends on the same major version of cargo-credential
otherwise incompatible.

This PR

See #13004 for more.

e58b84d changed the shape of response of cargo credential protocol trait,
so credential plugins crates effectively depend on `[email protected]`.
However, `[email protected]` still depends on`[email protected]`.
They must depends on the same major version of `cargo-credential`
otherwise incompatible.

See rust-lang#13004 for more.
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.75.0. Please double check that you specified the right target!

@rustbot rustbot added A-credential-provider Area: credential provider for storing and retreiving credentials S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2023
@weihanglo weihanglo changed the title [beta-1.75.0] chore: bump cargo-credential-* crates as e58b84d broke stuff [beta-1.75.0] chore: bump cargo-credential-* crates as e58b84d broke stuff Nov 19, 2023
@ehuss
Copy link
Contributor

ehuss commented Nov 20, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2023

📌 Commit a821e6f has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2023
@bors
Copy link
Contributor

bors commented Nov 20, 2023

⌛ Testing commit a821e6f with merge 1d8b05c...

@bors
Copy link
Contributor

bors commented Nov 20, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 1d8b05c to rust-1.75.0...

@bors bors merged commit 1d8b05c into rust-lang:rust-1.75.0 Nov 20, 2023
21 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2023
…nglo

[beta-1.75] Update cargo

2 commits in 6790a5127895debec95c24aefaeb18e059270df3..1d8b05cdd1287c64467306cf3ca2c8ac60c11eb0
2023-11-10 17:09:35 +0000 to 2023-11-20 01:39:31 +0000
- [beta-1.75.0] chore: bump `cargo-credential-*` crates as e58b84d broke stuff (rust-lang/cargo#13009)
- [beta 1.75] Backport 1password fixes (rust-lang/cargo#12994)

r? ghost
@weihanglo weihanglo deleted the rust-1.75.0-bump-credential branch November 20, 2023 19:30
@ehuss ehuss added this to the 1.75.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-credential-provider Area: credential provider for storing and retreiving credentials S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants