-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta-1.75.0] chore: bump cargo-credential-*
crates as e58b84d broke stuff
#13009
Merged
bors
merged 1 commit into
rust-lang:rust-1.75.0
from
weihanglo:rust-1.75.0-bump-credential
Nov 20, 2023
Merged
[beta-1.75.0] chore: bump cargo-credential-*
crates as e58b84d broke stuff
#13009
bors
merged 1 commit into
rust-lang:rust-1.75.0
from
weihanglo:rust-1.75.0-bump-credential
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e58b84d changed the shape of response of cargo credential protocol trait, so credential plugins crates effectively depend on `[email protected]`. However, `[email protected]` still depends on`[email protected]`. They must depends on the same major version of `cargo-credential` otherwise incompatible. See rust-lang#13004 for more.
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
A-credential-provider
Area: credential provider for storing and retreiving credentials
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 19, 2023
weihanglo
changed the title
[beta-1.75.0] chore: bump cargo-credential-* crates as e58b84d broke stuff
[beta-1.75.0] chore: bump Nov 19, 2023
cargo-credential-*
crates as e58b84d broke stuff
@bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 20, 2023
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 20, 2023
…nglo [beta-1.75] Update cargo 2 commits in 6790a5127895debec95c24aefaeb18e059270df3..1d8b05cdd1287c64467306cf3ca2c8ac60c11eb0 2023-11-10 17:09:35 +0000 to 2023-11-20 01:39:31 +0000 - [beta-1.75.0] chore: bump `cargo-credential-*` crates as e58b84d broke stuff (rust-lang/cargo#13009) - [beta 1.75] Backport 1password fixes (rust-lang/cargo#12994) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-credential-provider
Area: credential provider for storing and retreiving credentials
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e58b84d changed the shape of response of cargo credential protocol trait,
so credential plugins crates effectively depend on
[email protected]
.However,
[email protected]
still depends on[email protected]
.They must depends on the same major version of
cargo-credential
otherwise incompatible.
This PR
[email protected]
[email protected]
[email protected]
See #13004 for more.