[beta 1.75] Backport 1password fixes #12994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r=ehuss cargo-credential-1password: Add missing `--account` argument to `op signin` command ### What does this PR try to resolve? Without this the account chooser is shown by the `op signin` command, even though the user has already specified an account via the `--account` command line argument to the `cargo-credential-1password` CLI. Note that the `--vault` in this case does not need to be forwarded to `op`, since it is irrelevant for the `op signin` command. ### How should we test and review this PR? - Have a 1password installation with multiple accounts - Use `global-credential-providers = ["cargo-credential-1password --account my.1password.com"]` in the cargo config file - Run e.g. `cargo publish` - Notice how you are seeing an account switcher even though `--account` was used - Apply this patch and notice that the account switcher is no longer there and the correct account is selected automatically ### Additional information see https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/1password.20credentials.20provider
cargo-credential-1password: Fix README ### What does this PR try to resolve? The README.md file of the cargo-credential-1password package does not match the implemented reality (anymore?). - `--sign-in-address` and `--email` are not actually supported by the implementation - manually calling `op signin` appears to be unnecessary This PR also adds configuration instructions directly to the README.md so that they show up on crates.io.
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
A-credential-provider
weihanglo
approved these changes
Nov 17, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 20, 2023
…nglo [beta-1.75] Update cargo 2 commits in 6790a5127895debec95c24aefaeb18e059270df3..1d8b05cdd1287c64467306cf3ca2c8ac60c11eb0 2023-11-10 17:09:35 +0000 to 2023-11-20 01:39:31 +0000 - [beta-1.75.0] chore: bump `cargo-credential-*` crates as e58b84d broke stuff (rust-lang/cargo#13009) - [beta 1.75] Backport 1password fixes (rust-lang/cargo#12994) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports these fixes to 1.75 for the cargo-credential-1password helper. I'd like to publish these fixes and get the docs updated sooner rather than later. Unfortunately it uses an unpublished version of cargo-credential, so I can't publish directly from master.
Backports:
--accountargument toop signincommand #12985 — cargo-credential-1password: Add missing--accountargument toop signincommand