Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163 Update Flank to 20.08.3 #164

Merged
merged 3 commits into from
Aug 26, 2020
Merged

#163 Update Flank to 20.08.3 #164

merged 3 commits into from
Aug 26, 2020

Conversation

piotradamczyk5
Copy link
Contributor

Update Flank to v20.08.3

@piotradamczyk5
Copy link
Contributor Author

hey @runningcode CircleCi build fails seems to be an issue of CI itself, do you know any workaround for it?

@CristianGM
Copy link
Contributor

CristianGM commented Aug 25, 2020

@piotradamczyk5

exit value 137

it means we are consuming more memory than what is available, maybe it's because the usual error (no idea how CircleCI works, but I guess it's similar to Travis) where the JVM tells gradle we have more memory (all the memory the real machine has) but the Docker is only allowed to consume a limited amount, in this case 4GB and 2 CPUs)

Maybe something as simple as a restart helps, but it will be hiding the real issue.

I don't know if that happened before with Fladle but if it didn't... does Flank consume more memory now than the previous version?

@piotradamczyk5
Copy link
Contributor Author

piotradamczyk5 commented Aug 25, 2020

@piotradamczyk5

exit value 137

it means we are consuming more memory than what is available, maybe it's because the usual error (no idea how CircleCI works, but I guess it's similar to Travis) where the JVM tells gradle we have more memory (all the memory the real machine has) but the Docker is only allowed to consume a limited amount, in this case 4GB and 2 CPUs)

Maybe something as simple as a restart helps, but it will be hiding the real issue.

I don't know if that happened before with Fladle but if it didn't... does Flank consume more memory now than the previous version?

I don't think that memory consumption increased significantly.
I am sure that Flank does not consume 4GB.
I do not have any permission even to re-run the job, so I do not have any idea how to handle this issue.

@piotradamczyk5
Copy link
Contributor Author

@piotradamczyk5

exit value 137

it means we are consuming more memory than what is available, maybe it's because the usual error (no idea how CircleCI works, but I guess it's similar to Travis) where the JVM tells gradle we have more memory (all the memory the real machine has) but the Docker is only allowed to consume a limited amount, in this case 4GB and 2 CPUs)
Maybe something as simple as a restart helps, but it will be hiding the real issue.
I don't know if that happened before with Fladle but if it didn't... does Flank consume more memory now than the previous version?

I don't think that memory consumption increased significantly.
I am sure that Flank does not consume 4GB.
I do not have any permission even to re-run the job, so I do not have any idea how to handle this issue.

Based on @pawelpasterz research Flank consumes around 0,64GB

@runningcode
Copy link
Owner

I switched the repo to github actions to fix the memory issues. Can you rebase from master to see if this fixes the problems?

@piotradamczyk5
Copy link
Contributor Author

I switched the repo to github actions to fix the memory issues. Can you rebase from master to see if this fixes the problems?

It solves the issue. Thank you!

@runningcode runningcode merged commit bc5e1f3 into runningcode:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants