Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full-junit-result configuration is missing #157

Closed
kozaxinan opened this issue Aug 4, 2020 · 3 comments
Closed

full-junit-result configuration is missing #157

kozaxinan opened this issue Aug 4, 2020 · 3 comments

Comments

@kozaxinan
Copy link
Contributor

full-junit-result is required parameter to have smart sharding. Flank/flank#902 is reported on flank side. And according to flank source code

https://github.com/Flank/flank/blob/master/test_runner/src/main/kotlin/ftl/reports/util/ReportManager.kt#L133
will call
https://github.com/Flank/flank/blob/master/test_runner/src/main/kotlin/ftl/gc/GcStorage.kt#L62
for uplading the file. Without full-junit-result or legacy-junit-result, I failed to configure smart sharding. New logic and keyword is introduced in Flank/flank#798.

@pawelpasterz
Copy link
Contributor

This should be resolved once #164 is merged

@kozaxinan
Copy link
Contributor Author

@pawelpasterz Does fladle gradle plugin has property for full-junit-result?. I dont see new property added in to code or docs or examples in #164.

@runningcode
Copy link
Owner

Fixed in #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants