Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly explain how to enable smart flank for Android in documentation #902

Closed
lcdsmao opened this issue Jul 20, 2020 · 1 comment · Fixed by #935
Closed

Clearly explain how to enable smart flank for Android in documentation #902

lcdsmao opened this issue Jul 20, 2020 · 1 comment · Fixed by #935
Labels

Comments

@lcdsmao
Copy link

lcdsmao commented Jul 20, 2020

Author the user story for this feature

As an Android developer, I want the documentation to clearly explain how to enable smart flank for Android.

Describe the solution you'd like
After exploring the source code, I found the config need to fulfill two requirements:

  • Set a valid value to smart-flank-gcs-path
  • Set either the legacy-junit-result or full-junit-result to be true

It would be better if the document could state these two points.😀

@kozaxinan
Copy link
Contributor

kozaxinan commented Aug 4, 2020

I am also struggling to enable smart sharding feature. According to code https://github.com/Flank/flank/blob/master/test_runner/src/main/kotlin/ftl/reports/util/ReportManager.kt#L133. Like original post suggest, legacy-junit-result or full-junit-result to be true. It is introduced in #798. And full-junit-result is not supported by flank doctor yml check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants