Process junit xml even when full junit is not enabled #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! The team will review this soon. |
adamfilipow92
previously approved these changes
Aug 6, 2020
jan-goral
previously approved these changes
Aug 7, 2020
There was a problem hiding this comment.
@kozaxinan Great thanks for your contribution and recommendation!
We will implement proper validation for the clash of full-junit-result and legacy-junit-result.
|
I will update the release notes and merge if everything looks good. Next step is preparing fladle for full xml report. |
bootstraponline
dismissed stale reviews from jan-goral and adamfilipow92
via
53cc854
bootstraponline
approved these changes
Aug 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
#798 introduced a new argument
full-junit-result. It is false by default. First problem, it is not added to keys list so flank doctor report new argument as unknown key.Second problem is about junit xml report for smart flank run.
full-junit-resultandlegacy-junit-resultare used to decide to send junit report. As I understand from #798, there are now there junit result, legacy and full. Consideration; when both flag are true, flank can throw exception at argument checking phase.Test Plan
While using flank without legacy and full junit test report, smart test sharding and junit xml upload need to work.
Checklist