Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates "Dude, Where's My Stuff?" to v2.7.0 and adds Google Sheet API Verification Metadata #6254

Closed
wants to merge 2 commits into from

Conversation

jaybyrrd
Copy link

@jaybyrrd jaybyrrd commented Jul 7, 2024

What's New?

New features

  • Add Google Sheets data exporting, see README.md for more details (Big thanks to @jaybyrrd)

Full Changelog: Thource/[email protected]

@runelite-github-app
Copy link

runelite-github-app bot commented Jul 7, 2024

Includes non-plugin changes

Includes changes by non-author

dude-wheres-my-stuff: 37644bf348929e2540567fb1f955d812a4b5ca54...6672e8c123d79811c9bddb3c58e452e79a6bcc22

@jaybyrrd jaybyrrd marked this pull request as ready for review July 7, 2024 21:37
@jaybyrrd
Copy link
Author

jaybyrrd commented Jul 7, 2024

Fixes the issue in #6252

@YvesW
Copy link
Member

YvesW commented Jul 7, 2024

Thource should do that himself in that PR. Also beware that reviewing dependencies might take a very long time.

Additionally, there's already a google sheets API that got reviewed. Try using that.

@jaybyrrd
Copy link
Author

jaybyrrd commented Jul 7, 2024

Gotcha. We didn't know if it matters who raises the change since we have been working together on getting this released. In his PR he mentioned reaching to me to work on the issue he ran into.

With regard to api versions, we are using a major version that is significantly more recent than the one available. Also we don't know when they intend to update. Can we raise an issue on their plugin to update to this version? It seems prudent to prefer newer versions over older ones on dependencies like these.

On dependency review, totally understood. I can take a closer look but I think all of them are managed by Google so I hope that helps.

@YvesW
Copy link
Member

YvesW commented Jul 7, 2024

  1. Like I said, Thource has to do it in his own PR. He's the only author of the plugin. If he wants to add you, he has to add you to the plugin file before your PRs are allowed to be merged into the hub for his plugin.
  2. They probably aren't changing dependency versions, since it requires reviewing all changes made to it/potentially reviewing the whole dependency again. Asking them to use a newer version is useless; if you'd require a newer version, you'd just add it as dependency.
  3. Reviewing a dependency takes a lot of time and only one of the reviewers does this. Expect it to probably take months. Thus, try using the already reviewed version.

@jaybyrrd
Copy link
Author

jaybyrrd commented Jul 8, 2024

@YvesW our package takes non transitive dependencies on other packages too and will require a review regardless I think. Who typically does the review? We are happy to go through the right process. Perhaps the process can be lighter since the packages are related/the same and it's mainly versioning.

We can certainly have Thource raise the pull request.

@Felanbird
Copy link
Contributor

Duplicate of #6252

@Felanbird Felanbird marked this as a duplicate of #6252 Jul 8, 2024
@Felanbird Felanbird closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants