Update "Dude, Where's My Stuff?" to v2.7.0 #6252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Includes non-plugin changes
|
Thource
force-pushed
the
dude-wheres-my-stuff
branch
from
2c8e6fb
to
ea91d5d
Compare
Thource
force-pushed
the
dude-wheres-my-stuff
branch
from
ea91d5d
to
f30ab90
Compare
|
Sorry, trying to create a PR for hotfix and accidentally pushed to this branch |
|
@Thource as a reminder you pushed this branch to have no changes, also I pushed this plugin back 1 commit to before the cat_h changes, just so you are aware when/if you resolve this PR. |
Thource
force-pushed
the
dude-wheres-my-stuff
branch
from
6406ac6
to
59e3509
Compare
|
Thanks @Felanbird, I believe this should be ready now |
Thource
force-pushed
the
dude-wheres-my-stuff
branch
from
138b3eb
to
c154081
Compare
jaybyrrd
reviewed
Sep 25, 2024
Comment on lines
+1420
to
+1427
| <component group="org.xerial" name="sqlite-jdbc" version="3.46.0.0"> | ||
| <artifact name="sqlite-jdbc-3.46.0.0.jar"> | ||
| <sha256 value="e697df15be3f95219d80773c5f1002030e33e932adda186c1c86fd51df6691a9" origin="Generated by Gradle"/> | ||
| </artifact> | ||
| <artifact name="sqlite-jdbc-3.46.0.0.pom"> | ||
| <sha256 value="3c16325e9917957ada3cda84fb50296145aa4f3aa73e7a5d63af9719cee2a7ac" origin="Generated by Gradle"/> | ||
| </artifact> | ||
| </component> |
There was a problem hiding this comment.
Am I missing something? This doesn't actually seem different, just moved.
|
Is there a reason you need the newer gsheets dependency? Does |
LlemonDuck
added
the
waiting for author
|
We thought it’d be best to use an updated version, rather than the 2019 version. See here: https://discord.com/channels/301497432909414422/419891709883973642/1259902701165351053
…
On Nov 12, 2024 at 3:20 AM, <Rhea ***@***.***)> wrote:
Is there a reason you need the newer gsheets dependency? Does v4-rev581-1.25.0, which is already approved, no longer work?
—
Reply to this email directly, view it on GitHub (#6252 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AA7KA5KPTSWQPUFBMK76XKL2AFXXVAVCNFSM6AAAAABKOZZN7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGUYTCMZXHA).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
runelite-github-app
bot
removed
the
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: https://github.com/Thource/dude-wheres-my-stuff/releases/tag/v2.7.0