Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add fullnameOverride, nameOverride and global to values.schema.json #333

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix: add fullnameOverride, nameOverride and global to values.schema.json #333

merged 1 commit into from
Nov 14, 2023

Conversation

roytev
Copy link
Contributor

@roytev roytev commented Nov 14, 2023 •
edited
Loading

what

  • Add missing values to the values.schema.json

tests

  • helm templating and lint

references

@roytev roytev requested a review from a team as a code owner November 14, 2023 20:04
@jamengual jamengual merged commit b6fe4af into runatlantis:main Nov 14, 2023
2 checks passed
@jamengual
Copy link
Contributor

thanks @roytev

@cilindrox
Copy link
Contributor

thanks @roytev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.17.0 values.schema.json doesn't allow for fullnameOverride
3 participants
@roytev @jamengual @cilindrox