Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.17.0 values.schema.json doesn't allow for fullnameOverride #331

Closed
sharkymcdongles opened this issue Nov 13, 2023 · 3 comments · Fixed by #333
Closed

4.17.0 values.schema.json doesn't allow for fullnameOverride #331

sharkymcdongles opened this issue Nov 13, 2023 · 3 comments · Fixed by #333

Comments

@sharkymcdongles
Copy link

When upgrading to 4.17.0, fullnameOverride is no longer allowed due to the new values.schema.json file:

✗ Helm upgrade failed: values don't meet the specifications of the schema(s) in the following chart(s):
atlantis:
- (root): Additional property fullnameOverride is not allowed

Either remove the value or allow it in the schema.

@cilindrox
Copy link
Contributor

In addition to the above, I'm also running into an issue with the global prop not being allowed:

atlantis:
- (root): Additional property global is not allowed

This is triggered when including Atlantis as a subchart/dep.

@KeenanLawrence
Copy link

This value is still being used in the _helpers.tpl. Particularly important for our use case because we require a specific service name and this (or nameOverride) is the only way to set it.

@jamengual
Copy link
Contributor

@roytev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants