Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove llama-index-legacy dependency in llama-index-core #17231

Conversation

Digma
Copy link
Contributor

@Digma Digma commented Dec 10, 2024

Description

Follow-up on discussion in #16974. Thanks @masci

Removing the mention to llama-index-legacy which has side effects like requiring tenacity<0.9.0

Let me know if there is anything else to change.

I assume the corresponding lock files are generated automatically on merge Seems like test are failing so pushed the updated poetry.lock

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 10, 2024
@logan-markewich
Copy link
Collaborator

@Digma any way you can give me push permissions to this branch/repo? I'd like to update the docs pages the mention or use llama-index-legacy

@Digma
Copy link
Contributor Author

Digma commented Dec 10, 2024

@logan-markewich Thanks for having a look. I added you to the repo. Let me know if the permission are sufficient.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 10, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) December 10, 2024 18:07
@logan-markewich logan-markewich merged commit ea139e9 into run-llama:main Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants