Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: delete llama-index-legacy #16974

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

logan-markewich
Copy link
Collaborator

The package is still published and available, but this doesn't need to be in our codebase anymore

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 15, 2024
Copy link
Member

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@logan-markewich logan-markewich merged commit 293709e into main Nov 15, 2024
11 checks passed
@logan-markewich logan-markewich deleted the logan/delete_legacy branch November 15, 2024 16:57
@Digma
Copy link
Contributor

Digma commented Dec 10, 2024

@logan-markewich Is there any reason it is still mention in https://github.com/run-llama/llama_index/blob/main/pyproject.toml#L52C1-L52C31 ?

In our case, llama-index-legacy depends on tenacity<0.9.0 which is causing some issues with other dependencies we have. We were wondering if there is any reason to still have llama-index-legacy as a dependency in llama-index-core?

@masci
Copy link
Member

masci commented Dec 10, 2024

@Digma that's most likely a leftover, would you have time to open a PR to remove it from there?

@Digma
Copy link
Contributor

Digma commented Dec 10, 2024

Sure, will do it today

@logan-markewich
Copy link
Collaborator Author

Also @Digma for non-beginners (and also as a workaround), I really recommend not depending on llama-index at all. Use llama-index-core + the other packages you actually need. The top level llama-index package is just a wrapper on several starter packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants