Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brazilian Portuguese translation #108

Merged
merged 12 commits into from Nov 8, 2020
Merged

Add Brazilian Portuguese translation #108

merged 12 commits into from Nov 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2020

Hello❗(emoji extracted from Awesome Emoji Picker)

I am creating the translation for Brazilian Portuguese as a pull request, according to what was required on #107

This is my first pull request on GitHub, so please inform me if any errors were made.

@rugk, I translated the add-on listings on AMO as well, after you mentioned it.

@rugk rugk linked an issue Nov 2, 2020 that may be closed by this pull request
@rugk
Copy link
Owner

rugk commented Nov 2, 2020

Hi @marceloaof,
thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

Thanks for your translation.
Please subscribe to #27 to get notified for new updates on translations etc. 😃

Also note you can (automatically) let issues close when a PR is merged by adding some "magic" text to your PR body. (Manually linked it now.)

I'll review this soon.

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small change. Otherwise LGTM.

So congratulations to your first PR! 😃

src/_locales/pt-BR/messages.json Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Nov 2, 2020

Vielen Dank for your guidance, @rugk 😘 Now I understand my errors on GitHub thanks to you.

Following your suggestion, I have subscribed myself to receive notifications about new translations. Therefore, I will be able to assist in translating the project when it is available to translate the names of the emojis. 📝 Recently, other project was able to achieve that. I inform you in the hope to advance that scenario here.

Rugk, what on German do you mean by hacking on it? 🙃 Hab viel Spass?

@rugk
Copy link
Owner

rugk commented Nov 3, 2020

Well hacking on it is just what you do, contributing to it. Was just little colloquial term referring to the original meaning.

@rugk
Copy link
Owner

rugk commented Nov 3, 2020

Ah BTW another question: Could we use it for pt (i.e. portguese, all variants) or does it need to be only shown for pt-BR?

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a potential review from @CGReinhold (Portuguese translator in Offline QR Code). Unless there are objections, this will be merged soon.

@ghost
Copy link
Author

ghost commented Nov 3, 2020

Hello, @rugk
👍 Undoubtedly, reading Brazilian Portuguese on this add-on is a better experience for natives of Portugal, Angola and other countries than English currently is.
👉 However, while people say in Portuguese from Portugal (and in German) that "du kannst und das Add-on kann", in Brazilian Portuguese people say "du kann und das Add-on kann".
🔜 The translation I sent is understandable to Portuguese readers, but some nuances will be noticeable to non-Brazilians.
You may either offer the translation as portuguese in general (pt), making the distinction in the future, or offer it duplicated (pt-br + pt). A native from Portugal will need to make low priority corrections for the translation granted to Portugal.

@rugk
Copy link
Owner

rugk commented Nov 4, 2020

Well, what is/are your suggestions, @marceloaof and @CGReinhold? As I don't know this language I don't know how big the distraction would be to offer it as pt.

@CGReinhold
Copy link

I don't think that it would be a big problem offering it as pt since the differences are not big and most softwares already have only the brazilian portuguese option. Since there isn't currently a Portuguese translator, I believe that this is the way to go.

@rugk rugk merged commit 9e40a68 into rugk:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated translations for 'pt-BR': Portuguese (Português), Brazil
2 participants