desktop: Set main window as parent of file pickers #17403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this were to be merged before a release, you'd need to add PolyMeilex here: Lines 78 to 82 in 117df6e |
kjarosh
force-pushed
the
file-picker-parent
branch
3 times, most recently
from
6e3971b
to
ce39201
Compare
torokati44
force-pushed
the
file-picker-parent
branch
from
ce39201
to
0596e60
Compare
kjarosh
force-pushed
the
file-picker-parent
branch
from
0596e60
to
8a9c07e
Compare
|
The PR PolyMeilex/rfd#209 has been merged, I think we can now consider switching to a commit from rfd's |
evilpie
approved these changes
Aug 20, 2024
This patch makes sure that all file pickers are children of Ruffle. This way, file pickers will hover over the main window and will have to be dismissed before the user may interact with it.
kjarosh
force-pushed
the
file-picker-parent
branch
from
8a9c07e
to
fe6fedc
Compare
|
Tested on both Wayland and X11, and it works flawlessly, merging |
evilpie
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11336 a bit.
This patch makes sure that all file pickers are children of Ruffle. This way, file pickers will hover over the main window and will have to be dismissed before the user may interact with it.
Related functionality added in rfd:
set_parentin XDG portals PolyMeilex/rfd#209