Add support for set_parent in XDG portals
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HasDisplayHandle is required for Wayland to work.
PolyMeilex
approved these changes
Aug 10, 2024
|
Thank you for your review! I've added installing |
|
Thanks! |
|
Is there maybe a timeline for when a release with this feature included in it is planned to be released? 👀😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #46.
This PR ads support for
set_parentfor XDG Portals. As mentioned in #46, that requires making the parent to beHasWindowHandle + HasDisplayHandledue toWindowIdentifieron Wayland requiring aRawDisplayHandle.Currently the code calls
block_onwhen constructing aWindowIdentifierdue to the fact that the handles are notSend, but it's much better compared to not having the feature at all :)Tested on X11.