Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: suggested changes to impact radius #1764

Merged
merged 1 commit into from
Jan 10, 2023
Merged

feat: suggested changes to impact radius #1764

merged 1 commit into from
Jan 10, 2023

Conversation

sandeepdsvs
Copy link
Contributor

@sandeepdsvs sandeepdsvs commented Jan 9, 2023 •
edited
Loading

Description of the change

Suggested few changes relating to checkConfigurationError function (now renamed to validateConfigFields).

  • Now throwing error in transform.js/ processEvent instead of inside checkConfigurationError.
  • Now throwing error for all the missing fields at once.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sandeepdsvs sandeepdsvs requested a review from a team as a code owner January 9, 2023 15:31
@sandeepdsvs sandeepdsvs requested review from krishna2020, saikumarrs and ujjwal-ab and removed request for a team January 9, 2023 15:31
@sandeepdsvs sandeepdsvs marked this pull request as draft January 9, 2023 15:32
ujjwal-ab
ujjwal-ab reviewed Jan 9, 2023
View reviewed changes
test/__tests__/data/impact_radius.json
@@ -244,7 +244,7 @@
}
},
"output": {
"error": "accountSID is a required field"
"error": "accountSID : are required fields"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this error message looks correct?

@ujjwal-ab ujjwal-ab marked this pull request as ready for review January 10, 2023 03:36
@ujjwal-ab ujjwal-ab merged commit 4a18bac into impact_radius_destination Jan 10, 2023
ujjwal-ab added a commit that referenced this pull request Jan 10, 2023
@ujjwal-ab @ItsSudip @sandeepdsvs
feat: [impact radius] onboard impact radius cloud mode destination (#…
8d55c24 
…1730)

* feat: onboard impact-radius cloud mode destination

* feat: update mappings for track call

* update property mappings

* update products mapping and event filtering support

* refactor code

* add some fixes

* update property mapping

* refactor code

* add test cases

* fix clickId mapping

* update mapping

* test update unit tests

* removes duplicate mapping

* refactor code

* refactor code and add documentation for functions

* suggested changes (#1764)

* fix: update package.json

Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: Sandeep Digumarty <[email protected]>
@devops-github-rudderstack devops-github-rudderstack deleted the impact_radius_suggestions branch April 10, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjwal-ab ujjwal-ab ujjwal-ab left review comments

@krishna2020 krishna2020 Awaiting requested review from krishna2020 krishna2020 was automatically assigned from rudderlabs/integrations

@saikumarrs saikumarrs Awaiting requested review from saikumarrs saikumarrs was automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandeepdsvs @ujjwal-ab