Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [impact radius] onboard impact radius cloud mode destination #1730

Merged
merged 23 commits into from
Jan 10, 2023
Merged

feat: [impact radius] onboard impact radius cloud mode destination #1730

merged 23 commits into from
Jan 10, 2023

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

Onboard Impact Radius cloud mode destination

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab self-assigned this Dec 23, 2022
@ujjwal-ab ujjwal-ab marked this pull request as ready for review December 26, 2022 04:30
@ujjwal-ab ujjwal-ab requested a review from a team as a code owner December 26, 2022 04:30
@ujjwal-ab ujjwal-ab requested review from a team and sivashanmukh as code owners December 30, 2022 01:44
@ujjwal-ab ujjwal-ab requested a review from ItsSudip January 6, 2023 07:36
ItsSudip
ItsSudip previously approved these changes Jan 9, 2023
View reviewed changes
sandeepdsvs
sandeepdsvs previously approved these changes Jan 10, 2023
View reviewed changes
ItsSudip
ItsSudip previously approved these changes Jan 10, 2023
View reviewed changes
@ujjwal-ab ujjwal-ab requested a review from utsabc January 10, 2023 04:37
@ujjwal-ab ujjwal-ab dismissed stale reviews from ItsSudip and sandeepdsvs via b02872c January 10, 2023 05:05
@ujjwal-ab ujjwal-ab merged commit 8d55c24 into master Jan 10, 2023
@github-actions github-actions bot mentioned this pull request Jan 10, 2023
Merged
@devops-github-rudderstack devops-github-rudderstack deleted the impact_radius_destination branch April 11, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@sandeepdsvs sandeepdsvs sandeepdsvs approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

Assignees

@ujjwal-ab ujjwal-ab

Labels
new-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ujjwal-ab @utsabc @ItsSudip @sandeepdsvs