Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration): add common util function for mapping event names in ads destinations #643

Merged
merged 10 commits into from
Sep 14, 2022
Merged

feat(integration): add common util function for mapping event names in ads destinations #643

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bafb881
add common util function for mapping, onboard googleads changes
yashasvibajpai Sep 8, 2022
9d27287
add snap pixel support for ui mapping
yashasvibajpai Sep 10, 2022
a00ff7c
add reddit pixel support for ui mapping
yashasvibajpai Sep 10, 2022
a218b40
utilise the added common util in the integrations
yashasvibajpai Sep 12, 2022
787a3ce
add eventsToEvents mapping configuration to facebook pixel
yashasvibajpai Sep 12, 2022
eb03315
support one to many mapping for events, revert fb pixel changes
yashasvibajpai Sep 13, 2022
8d3f21d
address review comments
yashasvibajpai Sep 14, 2022
cc3f5fb
remove unused declarations, refactor
yashasvibajpai Sep 14, 2022
c22d5d1
Merge branch 'v1-staging' into feature/event-mapping-support
yashasvibajpai Sep 14, 2022
6acdc3e
Better nomenclature for function
yashasvibajpai Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions integrations/GoogleAds/browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
/* eslint-disable class-methods-use-this */
import logger from "../../utils/logUtil";
import { LOAD_ORIGIN } from "../ScriptLoader";
import { removeUndefinedAndNullValues } from "../utils/commonUtils";
import {
getHashFromArray,
ItsSudip marked this conversation as resolved.
Show resolved Hide resolved
getHashFromArrayWithDuplicate,
removeUndefinedAndNullValues,
setEventMappingFromConfig,
} from "../utils/commonUtils";
import { NAME } from "./constants";

class GoogleAds {
Expand All @@ -16,6 +21,7 @@ class GoogleAds {
this.conversionLinker = config.conversionLinker || true;
this.disableAdPersonalization = config.disableAdPersonalization || false;
this.name = NAME;
this.eventsMap = config.eventsMap;
}

init() {
Expand Down Expand Up @@ -83,7 +89,15 @@ class GoogleAds {
window.gtag("event", eventName, properties);
}
} else {
const { event } = rudderElement.message;
let { event } = rudderElement.message;
saikumarrs marked this conversation as resolved.
Show resolved Hide resolved
// modify the event name to mapped event name from the config
const eventsHashmap = getHashFromArrayWithDuplicate(
this.eventsMap,
"from",
"to",
false
);
event = setEventMappingFromConfig(event, eventsHashmap);
if (!event) {
logger.error("Event name not present");
return;
Expand Down
70 changes: 46 additions & 24 deletions integrations/RedditPixel/browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,17 @@
import logger from "../../utils/logUtil";
import { LOAD_ORIGIN } from "../ScriptLoader";
import { NAME } from "./constants";
import {
getHashFromArray,
getHashFromArrayWithDuplicate,
setEventMappingFromConfig,
} from "../utils/commonUtils";

class RedditPixel {
constructor(config) {
this.advertiserId = config.advertiserId;
this.name = NAME;
this.eventMappingFromConfig = config.eventMappingFromConfig;
}

init() {
Expand All @@ -30,7 +36,7 @@ class RedditPixel {
p.callQueue = [];
var t = d.createElement("script");
(t.src = "https://www.redditstatic.com/ads/pixel.js"), (t.async = !0);
(t.setAttribute("data-loader", LOAD_ORIGIN));
t.setAttribute("data-loader", LOAD_ORIGIN);
var s = d.getElementsByTagName("script")[0];
s.parentNode.insertBefore(t, s);
}
Expand Down Expand Up @@ -62,29 +68,45 @@ class RedditPixel {
logger.error("Event name is not present");
return;
}

switch (event.toLowerCase()) {
case "product added":
window.rdt("track", "AddToCart");
break;
case "product added to wishlist":
window.rdt("track", "AddToWishlist");
break;
case "order completed":
window.rdt("track", "Purchase");
break;
case "lead":
window.rdt("track", "Lead");
break;
case "view content":
window.rdt("track", "ViewContent");
break;
case "search":
window.rdt("track", "Search");
break;
default:
logger.error(`Invalid event ${event}. Track call not supported`);
break;
const eventMappingFromConfigMap = getHashFromArrayWithDuplicate(
this.eventMappingFromConfig,
"from",
"to",
false
);
if (eventMappingFromConfigMap[event]) {
// mapping event from UI
const events = setEventMappingFromConfig(
event,
eventMappingFromConfigMap
);
events.forEach((ev) => {
window.rdt("track", events[ev]);
utsabc marked this conversation as resolved.
Show resolved Hide resolved
});
} else {
switch (event.toLowerCase()) {
case "product added":
window.rdt("track", "AddToCart");
break;
case "product added to wishlist":
window.rdt("track", "AddToWishlist");
break;
case "order completed":
window.rdt("track", "Purchase");
break;
case "lead":
window.rdt("track", "Lead");
break;
case "view content":
window.rdt("track", "ViewContent");
break;
case "search":
window.rdt("track", "Search");
break;
default:
logger.error(`Invalid event ${event}. Track call not supported`);
break;
}
}
}

Expand Down
Loading