Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integration): add common util function for mapping event names in ads destinations #643

Merged
merged 10 commits into from
Sep 14, 2022
Merged

feat(integration): add common util function for mapping event names in ads destinations #643

merged 10 commits into from
Sep 14, 2022

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Sep 8, 2022 •
edited
Loading

Description of the change

Expose a mapping UI for the following ads destinations and support mapping event names to be set from the dashboard:

  1. Google Ads
  2. Reddit Pixel
  3. Snap Pixel

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@yashasvibajpai yashasvibajpai added enhancement New feature or request DO NOT MERGE labels Sep 8, 2022
@yashasvibajpai yashasvibajpai self-assigned this Sep 8, 2022
@yashasvibajpai yashasvibajpai marked this pull request as ready for review September 12, 2022 11:14
@saikumarrs saikumarrs changed the title enhancement (integration):add common util function for mapping event names in ads destinations feat (integration): add common util function for mapping event names in ads destinations Sep 12, 2022
@saikumarrs saikumarrs changed the title feat (integration): add common util function for mapping event names in ads destinations feat(integration): add common util function for mapping event names in ads destinations Sep 12, 2022
utsabc
utsabc reviewed Sep 14, 2022
View reviewed changes
integrations/SnapPixel/browser.js Outdated Show resolved Hide resolved
integrations/RedditPixel/browser.js Outdated Show resolved Hide resolved
ItsSudip
ItsSudip requested changes Sep 14, 2022
View reviewed changes
integrations/GoogleAds/browser.js Outdated Show resolved Hide resolved
integrations/GoogleAds/browser.js Outdated Show resolved Hide resolved
integrations/GoogleAds/browser.js Show resolved Hide resolved
integrations/SnapPixel/browser.js Show resolved Hide resolved
integrations/utils/commonUtils.js Outdated Show resolved Hide resolved
ItsSudip
ItsSudip previously approved these changes Sep 14, 2022
View reviewed changes
saikumarrs
saikumarrs previously approved these changes Sep 14, 2022
View reviewed changes
integrations/utils/commonUtils.js Outdated Show resolved Hide resolved
integrations/GoogleAds/browser.js Outdated Show resolved Hide resolved
utsabc
utsabc previously approved these changes Sep 14, 2022
View reviewed changes
integrations/utils/commonUtils.js Show resolved Hide resolved
@yashasvibajpai yashasvibajpai dismissed stale reviews from utsabc and saikumarrs via 6acdc3e September 14, 2022 08:39
@yashasvibajpai yashasvibajpai merged commit 96b8fee into v1-staging Sep 14, 2022
@yashasvibajpai yashasvibajpai deleted the feature/event-mapping-support branch September 14, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@ItsSudip ItsSudip ItsSudip left review comments

@utsabc utsabc utsabc left review comments

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@akashrpo akashrpo Awaiting requested review from akashrpo

Assignees

@yashasvibajpai yashasvibajpai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yashasvibajpai @utsabc @ItsSudip @saikumarrs