Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix : sriptloader async logic update #385

Merged
merged 18 commits into from
Dec 8, 2021
Merged

bugfix : sriptloader async logic update #385

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
aa864b8
Google optimize onboarding
abandonned Dec 3, 2021
6d920a2
Google optimize onboarding
abandonned Dec 3, 2021
6adaf41
added scriptloader for sync
abandonned Dec 3, 2021
76c3bc9
added src and id in scriptloader
abandonned Dec 3, 2021
1ccd4f0
updated the Scriptloader utility function and browser file
abandonned Dec 6, 2021
9d3a557
added anti flicker support and check for google analytics
abandonned Dec 6, 2021
cdd16d8
moved container id check to top and code optimization
abandonned Dec 6, 2021
9f16a70
added isready and isloaded function and removed check of sync for ant…
abandonned Dec 6, 2021
d076fb6
anti flicker snippet support
abandonned Dec 7, 2021
d3d3842
anti flicker snippet pushed to script tag
abandonned Dec 7, 2021
bf62731
added style before script
abandonned Dec 7, 2021
6865318
Merge branch 'production-staging' into dest-optimize
abandonned Dec 7, 2021
5e800ec
removed flickerObj and added some comments
abandonned Dec 7, 2021
bc0c142
scriptloader update in async logic
abandonned Dec 8, 2021
847ecb1
Merge branch 'production-staging' into dest-optimize
abandonned Dec 8, 2021
a260096
optimize
abandonned Dec 8, 2021
f7584da
added defaultState variable and assigned true to parameter of scriptl…
abandonned Dec 8, 2021
9176d3c
var name update
abandonned Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions integrations/ScriptLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
/* eslint-disable no-use-before-define */
import logger from "../utils/logUtil";
const defaultAsyncState = true;

const ScriptLoader = (id, src, async) => {
const ScriptLoader = (id, src, async = defaultAsyncState) => {
logger.debug(`in script loader=== ${id}`);
const js = document.createElement("script");
js.src = src;
js.async = async || true;
js.async = async === undefined ? defaultAsyncState : async;
js.type = "text/javascript";
js.id = id;
const e = document.getElementsByTagName("script")[0];
Expand Down