Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix : sriptloader async logic update #385

Merged
merged 18 commits into from
Dec 8, 2021
Merged

bugfix : sriptloader async logic update #385

merged 18 commits into from
Dec 8, 2021

Conversation

abandonned
Copy link
Contributor

@abandonned abandonned commented Dec 8, 2021 •
edited by SumanthPuram
Loading

Description of the change

Since async carries boolean value it was doing logical operation instead of assignment.
Have tested it.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@abandonned abandonned added the Ready for review Changes are ready to be reviewed label Dec 8, 2021
@abandonned abandonned requested a review from saikumarrs December 8, 2021 06:29
@abandonned abandonned self-assigned this Dec 8, 2021
@abandonned abandonned changed the base branch from production to production-staging December 8, 2021 06:29
@saikumarrs saikumarrs merged commit fa4202a into production-staging Dec 8, 2021
@saikumarrs saikumarrs deleted the dest-optimize branch December 8, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

Assignees

@abandonned abandonned

Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abandonned @saikumarrs