This repository has been archived by the owner on Aug 26, 2023. It is now read-only.
ci: add Ruby 3 to Github Actions and Appveyor #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2021
flavorjones
force-pushed
the
flavorjones-update-ci-ruby-versions
branch
from
136ae20 to
d32e3e9
Compare
|
@stevecheckoway @rubys How do y'all feel about me removing travis in this commit? I'm confident that the current Github Actions entirely reproduce, and are faster than, the Travis config. |
|
Thank you for doing this! I originally asked @rubys to add Appveyor because Travis didn't support Windows. Now that GitHub Actions supports Windows, is there any reason to keep Appveyor? It seems to be much slower. |
flavorjones
force-pushed
the
flavorjones-update-ci-ruby-versions
branch
from
d32e3e9 to
5ca85b8
Compare
flavorjones
force-pushed
the
flavorjones-update-ci-ruby-versions
branch
from
5ca85b8 to
8f00905
Compare
|
@stevecheckoway That's a good question, and I think the answer is probably "No." I'll probably put removal of appveyor in a separate PR just to make sure we get a solid "green" across both GA and Appveyor, which we haven't had. |
also: - Appveyor: - move to Visual Studio 2019 for Ruby 2.7 and 3.0 - remove Ruby 2.4 and earlier - Travis: drop entirely
flavorjones
force-pushed
the
flavorjones-update-ci-ruby-versions
branch
from
288b3da to
f1ca1b6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #139