Skip to content
This repository has been archived by the owner on Aug 26, 2023. It is now read-only.

GitHub Actions tests too often #168

Closed
stevecheckoway opened this issue Feb 26, 2021 · 6 comments
Closed

GitHub Actions tests too often #168

stevecheckoway opened this issue Feb 26, 2021 · 6 comments

Comments

@stevecheckoway
Copy link
Collaborator

The current GitHub Actions setup (which was mostly copied from somewhere else) builds and tests twice when pull requests are created. I think the behavior we want is to build/test once for each

  • push to master;
  • creation of a pull request; and
  • push to a pull request branch other than the first.

After skimming this, it's not obvious to me if it's possible or not possible.

flavorjones added a commit that referenced this issue Feb 26, 2021
@flavorjones
Copy link
Collaborator

I think I've fixed this with the most recent commit on #167

@stevecheckoway
Copy link
Collaborator Author

Will that still build on a push to a pull request branch? In other words, when a PR is opened, it will build. But if a change is made to the PR and then pushed, will that build again?

flavorjones added a commit that referenced this issue Feb 26, 2021
@flavorjones
Copy link
Collaborator

🤔 Let me test that.

@flavorjones
Copy link
Collaborator

@stevecheckoway You were right, they weren't being re-triggered. BRB, going to fix Nokogiri's Actions config.

@stevecheckoway
Copy link
Collaborator Author

That's too bad. There's probably a way to work around it, but it seems like something GitHub needs to fix.

@flavorjones
Copy link
Collaborator

@stevecheckoway Ah, found a thing that works, see a7ca22b

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants