Unify initialization of MFA #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4757 +/- ##
==========================================
- Coverage 97.15% 97.15% -0.01%
==========================================
Files 395 395
Lines 8379 8376 -3
==========================================
- Hits 8141 8138 -3
Misses 238 238 ☔ View full report in Codecov by Sentry. |
indirect
approved these changes
Jun 2, 2024
martinemde
force-pushed
the
martinemde/validate-webauthn
branch
from
cb353eb to
449a134
Compare
martinemde
force-pushed
the
martinemde/initialize-mfa
branch
from
9fb21ca to
cf3f754
Compare
jonatas
pushed a commit
to jonatas/rubygems.org
that referenced
this pull request
Jun 7, 2024
* initialize_mfa * prompt_mfa renders multifactor_auths/prompt * require_mfa abstracts initialize_mfa + prompt_mfa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further builds on #4756 with an abstraction around initializing mfa and requiring it for users that have it enabled.
Please review #4754 and #4756, each commit works on its own but requires the previous ones.