Unify OTP validation #4754
Merged
Unify OTP validation #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4754 +/- ##
==========================================
+ Coverage 97.14% 97.15% +0.01%
==========================================
Files 394 395 +1
Lines 8338 8379 +41
==========================================
+ Hits 8100 8141 +41
Misses 238 238 ☔ View full report in Codecov by Sentry. |
martinemde
force-pushed
the
martinemde/validate-otp
branch
2 times, most recently
from
33224ec to
8dce71b
Compare
martinemde
force-pushed
the
martinemde/validate-otp
branch
from
8dce71b to
dca321f
Compare
|
This ❌ is just code climate and I don't want to ignore one of them since it's fixed in the following PR once the refactor is complete. |
indirect
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to fix our password reset to avoid the link expiration, which lead me on a long path of discovering the ways in which our MFA is inconsistent across controllers.