-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3.3.6 update #6098
Ruby 3.3.6 update #6098
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.2.4 | ||
3.3.6 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
ruby 3.2.4 | ||
ruby 3.3.6 | ||
yarn 1.22.22 | ||
nodejs 22.11.0 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -669,7 +669,7 @@ DEPENDENCIES | |
wicked | ||
|
||
RUBY VERSION | ||
ruby 3.2.4p170 | ||
ruby 3.3.6p108 | ||
|
||
BUNDLED WITH | ||
2.5.23 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,6 @@ | |
</h3> | ||
<% min_date = CaseContact::MINIMUM_DATE %> | ||
<% current_date = Time.zone.today %> | ||
<% initial_value = @case_contact.occurred_at&.to_date %> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unused (warning) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's an erb, so probably used by js somewhere? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, but I only know that because I wrote it haha. I left this straggler. |
||
<%= form.date_field(:occurred_at, | ||
required: true, | ||
max: (current_date + 1.day).to_fs(:iso8601), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
casa_org = create(:casa_org, name: "Fake Name", display_name: "Fake Display Name") | ||
placement_type = create(:placement_type, casa_org: casa_org) | ||
creator = create(:user) | ||
placement = create(:placement, creator: creator, placement_type: placement_type) # rubocop:disable Lint/UselessAssignment | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unused var (warning) |
||
create(:placement, creator: creator, placement_type: placement_type) | ||
|
||
csv_headers = "Casa Org,Casa Case Number,Placement Type,Placement Started At,Created At,Creator Name\n" | ||
result = PlacementExportCsvService.new(casa_org: casa_org).perform | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,14 +15,7 @@ | |
Capybara.disable_animation = true | ||
|
||
Capybara::Screenshot.autosave_on_failure = true | ||
|
||
module Capybara | ||
module Screenshot | ||
def self.capybara_tmp_path | ||
Rails.root.join("tmp", "screenshots#{ENV["GROUPS_UNDERSCORE"]}") | ||
end | ||
end | ||
end | ||
Capybara.save_path = Rails.root.join("tmp", "screenshots#{ENV["GROUPS_UNDERSCORE"]}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. method redefined (warning). I'm like 90% sure this is equivalent, but may want to check CI artifacts work. |
||
|
||
options = Selenium::WebDriver::Chrome::Options.new | ||
options.add_argument("--disable-gpu") | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module PretenderContext | ||
def true_user | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixed a warning: private_class_method is ignored unless called with a symbol, like:
private_class_method :send_notification
or used this way.