Ruby 3.3.6 update #6098
Merged
Ruby 3.3.6 update #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
thejonroberts
commented
Nov 13, 2024
| private_class_method | ||
|
|
||
| def self.send_notification(followup, creator) | ||
| private_class_method def self.send_notification(followup, creator) |
There was a problem hiding this comment.
this fixed a warning: private_class_method is ignored unless called with a symbol, like:
private_class_method :send_notification
or used this way.
| @@ -54,7 +54,6 @@ | |||
| </h3> | |||
| <% min_date = CaseContact::MINIMUM_DATE %> | |||
| <% current_date = Time.zone.today %> | |||
| <% initial_value = @case_contact.occurred_at&.to_date %> | |||
There was a problem hiding this comment.
unused (warning)
There was a problem hiding this comment.
it's an erb, so probably used by js somewhere?
There was a problem hiding this comment.
No, but I only know that because I wrote it haha. I left this straggler.
| @@ -6,7 +6,7 @@ | |||
| casa_org = create(:casa_org, name: "Fake Name", display_name: "Fake Display Name") | |||
| placement_type = create(:placement_type, casa_org: casa_org) | |||
| creator = create(:user) | |||
| placement = create(:placement, creator: creator, placement_type: placement_type) # rubocop:disable Lint/UselessAssignment | |||
There was a problem hiding this comment.
unused var (warning)
| end | ||
| end | ||
| end | ||
| Capybara.save_path = Rails.root.join("tmp", "screenshots#{ENV["GROUPS_UNDERSCORE"]}") |
There was a problem hiding this comment.
method redefined (warning). I'm like 90% sure this is equivalent, but may want to check CI artifacts work.
thejonroberts
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
|
has merge conflicts now sorry :/ |
ran rspec with --warnings flag and fixed most of them in our code
thejonroberts
force-pushed
the
ruby-3.3.6
branch
from
878aab0 to
744c66a
Compare
|
@compwron no problem, rebased now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
No issue
What changed, and why?
Update ruby version
How is this tested? (please write tests!) 💖💪
Current specs only