Filtered reports generation #5593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose methods in court report context to make unit testing easier. Write additional unit tests. Remove old tests. Remove redundant tests, some behavior is already tested by the Dates object.
github-actions
bot
added
javascript
elasticspoon
force-pushed
the
filtered-reports-generation
branch
3 times, most recently
from
e2af233 to
943a49f
Compare
Add generate docx modal with date pickers to filter dates of case contacts to include in the generated report. Modify current tests to open the modal before attempting to click within it. Allow range filtering of contacts in case report
elasticspoon
force-pushed
the
filtered-reports-generation
branch
from
943a49f to
52fc2e6
Compare
elasticspoon
requested review from
compwron,
FireLemons and
littleforest
as code owners
compwron
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
I am in favor - I want to look at this more deeply when I have time. @FireLemons do you have time to review?
On the case show page it should autofill the start date of the date range with the most recent court date. This most closely mirrors existing behavior.
elasticspoon
force-pushed
the
filtered-reports-generation
branch
from
bedc63b to
b449a47
Compare
2 tasks
compwron
reviewed
Apr 15, 2024
| @@ -158,6 +158,12 @@ def most_recent_past_court_date | |||
| court_dates.where("date < ?", Date.today).order(:date).last | |||
| end | |||
|
|
|||
| def formatted_latest_court_date | |||
compwron
reviewed
Apr 15, 2024
| @@ -41,6 +41,58 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe "Report Generation", js: true do | |||
compwron
reviewed
Apr 15, 2024
| @@ -204,6 +171,7 @@ | |||
| end | |||
| end | |||
|
|
|||
| # TODO: make this a request spec | |||
|
changing reports generation makes me very nervous but I think this is reasonable |
|
screenshots are good... let's do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5579
Blocked by #5590
Fixes #3243 (i think? i just randomly found this issue)
To close issue still need to implement adding court topics, etc to reports themselves.
Reworks report generation page to use a modal and allow selection of contacts into report by date range.
New generate page with new button:
New modal with generation options:
Modal on both generation pages:
