refactor: expose court report methods

[elasticspoon]

Context

I will soon need to make a few changes to report generation and the current CaseCourtReportContext makes it very difficult to change behavior.

The Problem

Currently CaseCourtReportContext has a single public method that outputs a very complex object:

  {
    created_date: I18n.l(Time.current.in_time_zone(@time_zone).to_date, format: :full, default: nil),
    casa_case: prepare_case_details,
    case_contacts: prepare_case_contacts,
    case_court_orders: prepare_case_orders,
    case_mandates: prepare_case_orders, # backwards compatible with old Montgomery template - keep this! TODO test full generation
    latest_hearing_date: latest_hearing_date.nil? ? "___<LATEST HEARING DATE>____" : I18n.l(latest_hearing_date.date, format: :full, default: nil),
    org_address: org_address(is_default_template),
    volunteer: volunteer_info,
    hearing_type_name: @court_date&.hearing_type&.name || "None"
  }

The hash itself gets built using smaller methods but is tested by creating the full hash then inspecting each key. Ex:

expect(court_report_context.context[:casa_case][:court_date]).to eq("March 1, 2021")

This makes it hard to extend the behavior of the class and write additional tests.

What changed, and why?

This PR reworks some of the methods and tests for CaseCourtReportContext.

• Expose methods in court report context to make unit testing easier.
• Write additional unit tests.
• Remove old tests.
• Remove redundant tests, some behavior is already tested by CaseContactsContactDates.

How will this affect user permissions?

None

How is this tested? (please write tests!) 💖💪

Unit tests

[elasticspoon]

Not sure how best to test the case where there are interviewees, should I even test it?

  def case_contacts
    cccts = CaseContactContactType.includes(:case_contact, :contact_type).where("case_contacts.casa_case_id": @casa_case.id)
    interviewees = filter_out_old_case_contacts(cccts)
    return [] unless interviewees.size.positive?

    CaseContactsContactDates.new(interviewees).contact_dates_details
  end

All this could really test is that the ActiveRecord query is correct, and its not a very complex query. Is there value in it?

[compwron]

I am somewhat unclear on what an interviewee is
In general I am in favor of more testing rather than less tho

[compwron]

In general I am in favor of this but I am nervous about it possibly breaking court report generation somehow

[elasticspoon]

In general I am in favor of this but I am nervous about it possibly breaking court report generation somehow

It certainly could be just because the testing around report generation is pretty convoluted. That said these changes still pass all the tests directly related to report generation.

In my other PR I test the report like this:

casa/spec/models/case_court_report_spec.rb

Line 11 in deea6bb

context "#generate_to_string" do

Which imo makes it much easier to be sure we get all the edge cases. Ideally I would like to refactor the whole report test to be of that form. But it's a pretty big shift so idk.