Resolves move controller specs to request specs #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeGorge
requested review from
compwron,
FireLemons and
littleforest
as code owners
|
I didn't read through the details but I just wanted to say Good Effort! Phew, working through specs isn't always easy. |
littleforest
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #4129
What changed, and why?
Migrated all the remaining controller specs to request specs. The only ones left are concerns and ApplicationController specs which do not make sense to wright as request specs. As well as one overwrite of the ApplicationController on EmacipationsController.
Improved the emancipations specs to both account for what was tested in the controller spec and be better maintainable. Removed a bunch of specs here that are already tested as policy specs as well.
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feelings gif (optional)
It took a while guys, since my first PR on this, but this spec migration is finally finished!! 🎉