Move controller specs to request specs

[compwron]

Move controller specs to request specs - see https://github.com/rubyforgood/casa/blob/main/doc/architecture-decisions/0008-controller-specs.txt for why and how

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 6-8pm Pacific), stakeholder news, and upcoming new issues.

[farrelld09]

Claim

[github-actions]

This issue has been inactive for 249 hours (10.38 days) and will be unassigned after 111 more hours (4.63 days). If you have questions, please visit the #casa channel in slack during Tuesdays 6-8 PM PST. Link: https://rubyforgood.herokuapp.com/

If you are still working on this, comment here to tell the bot to give you more time

[github-actions]

This issue has been inactive for 369 hours (15.38 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

[sandfortw]

@compwron I am confused about something.

The controller spec file for casa_cases was deleted in this PR:

#3432

But then reintroduced here:

#3817

Was this an error? Can I safely delete it? Are we keeping some controller specs for some controllers for some reason?

I think almost all of the remaining controller specs have corresponding request spec files already.

[sandfortw]

Only application_controller_spec, static_controller_spec, and sessions_controller_spec do not already have corresponding request spec files. Is there anything left to do for this issue except remove the redundant controller specs?

Is the task that's left to make sure everything that is being tested in the current controller tests is also in the request tests, or are all of the existing controller tests supposed to remain, in which case this issue should be closed?

If I am fundamentally missing something, I may need to have this explained in office hours, or by someone who is willing to chat with me tomorrow or Friday.

[github-actions]

This issue has been inactive for 247 hours (10.29 days) and will be unassigned after 113 more hours (4.71 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

[github-actions]

This issue has been inactive for 367 hours (15.29 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.