Refactor court_dates_controller_specs to request specs #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
master CI is broken right now, this PR is ok to merge but I want master green first. |
compwron
approved these changes
Jan 27, 2023
|
Seems like a flickering spec. I guess I can't rerun it. |
|
It's a lint error. It can be fixed by running |
|
@anshu1992 The flickering test I mentioned was from a previous run. That lint problem is not from the files I changed. |
|
Ah, okay, my bad! |
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Part of #4129
Not closing yet as there will be more on the way.
What changed, and why?
The court_dates_controller_spec file was removed and its specs moved to court_dates_spec.
Notes:
court_date_policy_specso I added them there also.How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feedback please? (optional)
The destroy action for court dates controller is allowed to any supervisor or admin, not just the ones from the same org as the case. All the other actions follow a different rule (checking for same org as the case).
I found that a bit odd, maybe it's by design, but it doesn't hurt to point it out.