Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile support for notifier #5296

Merged
merged 23 commits into from
Oct 23, 2023
Merged

Mobile support for notifier #5296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
07e4dcb
notifier scrolls when there are too many notifications to display
FireLemons Oct 18, 2023
f917202
notifier keeps track of how many of each kind of notification there are
FireLemons Oct 18, 2023
75e0515
added toggle notification minimize button, styled it
FireLemons Oct 18, 2023
705311c
alphabetize notifier methods
FireLemons Oct 18, 2023
87c9fdb
notifier automatically shows/hides minimize button depending on prese…
FireLemons Oct 18, 2023
9d81575
block stubs for tests
FireLemons Oct 18, 2023
b642730
wrote test for minimize button hiding
FireLemons Oct 18, 2023
d3dc7e3
make setMinimizeButtonVisibility private
FireLemons Oct 19, 2023
91c870b
filled out notificationsCount tests
FireLemons Oct 20, 2023
1f51d5d
wrote test for totalNotificationCount
FireLemons Oct 20, 2023
159b64c
fixed notification positioning
FireLemons Oct 20, 2023
caba9c7
added badges for minimized notification display
FireLemons Oct 20, 2023
9389f95
moved notification messages to own div
FireLemons Oct 21, 2023
b639373
created toggleMinimize
FireLemons Oct 21, 2023
973b763
reduced jQuery lookups, made code simpler
FireLemons Oct 21, 2023
1e5c383
minimize button toggles minimize mode, fixed double instantiation of …
FireLemons Oct 21, 2023
981e80d
test stubs
FireLemons Oct 22, 2023
af321ae
made toggleMinimize private
FireLemons Oct 22, 2023
f8985e5
filled in test for minimize toggle
FireLemons Oct 22, 2023
021c3fc
filled out test for badge states after toggling minimize mode
FireLemons Oct 22, 2023
10c1430
filled out notify tests for minimize button
FireLemons Oct 23, 2023
1943353
filled in tests for dismiss
FireLemons Oct 23, 2023
81030da
update tests
FireLemons Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions app/assets/stylesheets/shared/notifier.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,19 @@
}

#notifications {
bottom: 2em;
bottom: 0;
display: flex;
flex-direction: column;
font-weight: 900;
max-height: 100vh;
overflow-y: auto;
position: fixed;
right: 2em;
z-index: 100;

div {
border-radius: .25em;
margin: .25em;
margin-bottom: .5em;
margin-left: auto;
margin-right: 0;
padding: .5em;
Expand All @@ -28,17 +30,22 @@
}
}

.failure-indicator {
.danger-notification {
background-color: #b71c1c;
color: white
}

.success-indicator {
.messages {
margin-bottom: 0;
padding: 0;
}

.success-notification {
background-color: #28a745;
color: white
}

.warn-indicator {
.warning-notification {
background-color: #ffc107;
}

Expand All @@ -58,4 +65,16 @@
width: 1em
}
}

#toggle-minimize-notifications {
background-color: #333;
border: 0;
border-radius: 10px 10px 0 0;
color: white;
padding: 0.25em 1em;

span {
display: inline;
}
}
}
Loading