Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile support for notifier #5296

Merged
merged 23 commits into from
Oct 23, 2023

Conversation

FireLemons
Copy link
Collaborator

@FireLemons FireLemons commented Oct 23, 2023

What changed, and why?

Created a minimize mode for the notifier
Notification overflow now scrolls without overlapping with the page's scrollbar

How is this tested? (please write tests!) 💖💪

Jest unit testing

Screenshots please :)

image
image

@github-actions github-actions bot added javascript for use by Github Labeler to mark pull requests that update Javascript code Tests! 🎉💖👏 erb labels Oct 23, 2023
@FireLemons FireLemons force-pushed the mobile_support_for_notifier branch from 205a2c5 to 81030da Compare October 23, 2023 13:22
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Oct 23, 2023
@FireLemons FireLemons merged commit 37aa769 into rubyforgood:main Oct 23, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant