-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile support for notifier #5296
Merged
FireLemons
merged 23 commits into
rubyforgood:main
from
FireLemons:mobile_support_for_notifier
Oct 23, 2023
Merged
Mobile support for notifier #5296
FireLemons
merged 23 commits into
rubyforgood:main
from
FireLemons:mobile_support_for_notifier
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce of notifications
…notifier on patch notes page
github-actions
bot
added
javascript
for use by Github Labeler to mark pull requests that update Javascript code
Tests! 🎉💖👏
erb
labels
Oct 23, 2023
FireLemons
force-pushed
the
mobile_support_for_notifier
branch
from
October 23, 2023 13:22
205a2c5
to
81030da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
erb
javascript
for use by Github Labeler to mark pull requests that update Javascript code
ruby
Pull requests that update Ruby code
Tests! 🎉💖👏
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed, and why?
Created a minimize mode for the notifier
Notification overflow now scrolls without overlapping with the page's scrollbar
How is this tested? (please write tests!) 💖💪
Jest unit testing
Screenshots please :)