Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix special_return method's result wrapping to be more dynamic #74

Merged
merged 6 commits into from
Jan 12, 2016
Merged

Fix special_return method's result wrapping to be more dynamic #74

merged 6 commits into from
Jan 12, 2016

Conversation

tscholz
Copy link
Contributor

@tscholz tscholz commented Sep 24, 2015

Hi,

there is a little issue with the FileList SPECIAL_RETURNs:

class CustomFileList < Rake::FileList
end

c = CustomFileList.new #=> []
c.class #=> CustomFileList

c.uniq.class #=> Rake::FileList but should be a CustomFileList

What do you think about this fix?

@hsbt
Copy link
Member

hsbt commented Oct 21, 2015

@drbrain Can you review this?

@tscholz
Copy link
Contributor Author

tscholz commented Nov 9, 2015

Hi,

any news on this?

@tscholz
Copy link
Contributor Author

tscholz commented Dec 11, 2015

@hsbt, @drbrain

Hi,
I'd like to kindly ask if someone could have a look at this? I know this is not a very important issue and I'm sure there are a lot of other things to do. Nevertheless it would be nice to see some progress on this.

hsbt
hsbt reviewed Jan 8, 2016
View reviewed changes
lib/rake/ext/time.rb
- other.<=>(self)
else
rake_original_time_compare(other)
if RUBY_VERSION < "1.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary for your issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change already merged in master.

@hsbt
Copy link
Member

hsbt commented Jan 8, 2016

@tscholz It strange behavior for me. Your proposal is reasonable. I will merge after your feedback on my comment.

hsbt added a commit that referenced this pull request Jan 12, 2016
@hsbt
Merge pull request #74 from tscholz/file_list_special_returns
9ff282b 
Fix special_return method's result wrapping to be more dynamic
@hsbt hsbt merged commit 9ff282b into ruby:master Jan 12, 2016
@tscholz tscholz mentioned this pull request Feb 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tscholz @hsbt @pabloh